Add parameters table1_name,table2_name in data_compare method.

Question

anilkumarpanda opened this issue 5 years ago · 2 comments

Current implementation of data_compare assigns default values of 'table1' and 'table2' to the dataframes.

However, it would be good if the user can specify name of the dataframe, to be able to distinguish the dataframes better.

The signature can be as follows:
distribution_compare_pretty(_df1, _df2, _df1_name='table1',_df2_name='table2', col, figsize=None, date_flag=False)

Answer 1 · 2020-04-12T14:40:15.000Z

I would be happy to make the changes, if you agree.

Answer 2 · 2020-04-12T14:42:03.000Z

Yes, please help create a PR and everyone can use the same function. 2020年4月12日(日) 午後10:40 Anilkumar Panda <notifications@github.com>:

I would be happy to make the changes, if you agree. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADXNPFFKLIUJCT6SX6WQTBLRMHHFXANCNFSM4MGN6LSQ> .