Show content in cutout area toggle missing?
bubin7766 opened this issue · 4 comments
Describe your suggested feature
This is a toggle that is present in the new versions of tachiyomi, but not in the current versions of J2K.
What makes this different from the current full screen toggle in tachiyomi is that it completely blacks out the cutout area. Whereas the full screen toggle gives it a grayscale like appearance and it applies to the entire app.
I've looked through Jays2Kings issues on github and found that he did Implement the toggle somewhat but only for landscape mode. So what I'm asking is for the same functionality in portrait mode if it's feasible
Other details
No response
Acknowledgements
- I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
- I have written a short but informative title.
- If this is an request for a feature in the original Tachiyomi, I am opening because multiple versions of TachiyomiS97 have been released without this feature.
- If this is an issue with an extension, or a request for an extension, I should be opening an issue in the extensions repository.
- I have updated the app to version 1.7.4.
- I have checked through the app settings for my feature.
So this is best viewed on a mobile device with a notch when viewing the screenshots.
But from top to bottom it will be a screenshot with
1st) Fullscreen enabled and show content in cutout enabled
2nd) Fullscreen disabled
3rd) Fullscreen enabled and show content in cutout disabled
4th) Toggles show in Tachiyomi S97
5th) Toggles show in newer forks
For the 1st screenshot this is the default viewing experience when Fullscreen is enabled and the toggle for show content in cutout area is enabled
If you look at the 2nd screenshot, when you disable the Full-screen toggle you'll notice that it does hide the cutout area but it shifts the UI around it in an unpleasant way.
Whereas the 3rd screenshot just hides the cutout area in the reader, While keeping the rest of the UI in a normal state
I've noticed Yokai has implemented this recently and even added further support than what Mihon/Tachiyomi has done so far, unfortunately the app doesn't seem to have a clear goal so I'd much rather see it implemented in a stable fork like this one
One quirk, I have noticed with the way tachiyomi's full screen toggle works is that it will always display the notification icons as shown in the screenshot below
This is when the full screen toggle is set to off in tachiyomi
In the newer versions of tachiyomi with the new "display content in cutout area" toggle set to off, this hides the notification content for just a solid black bar
Unfortunately this option requires me to have an android device. I only use WSA and the cutout setting is hidden there because its not applicable.
Feel free to develop this feature and submit a PR if you are interested. I don't plan to develop it anytime soon.