max-line-length (80 columns) seems too short
thompson318 opened this issue · 5 comments
In GitLab by @bongjinkoo on Feb 8, 2019, 10:58
I think 80 columns are too short: Some of the lines get really not pretty
as I have to linebreak due to this limit.
And, some lines (I didn't write) are just not possible to fit in 80 columns
and not possible to linebreak.
What about 120 columns?
In GitLab by @bongjinkoo on Feb 8, 2019, 11:24
assigned to @MattClarkson
In GitLab by @MattClarkson on Feb 8, 2019, 11:40
@StephenThompson @ThomasDowrick Im not religious on this. Any thoughts?
In GitLab by @ThomasDowrick on Feb 8, 2019, 11:51
I don't feel too strongly about it, but probably best to just add # pylint: disable=line-too-long, to disable the linter warning in functions that need it, such as in:
https://weisslab.cs.ucl.ac.uk/WEISS/SoftwareRepositories/SNAPPY/scikit-surgeryvtk/blob/master/sksurgeryvtk/camera/vtk_camera_model.py#L28
In GitLab by @bongjinkoo on Feb 8, 2019, 12:00
I looked it up a bit and the Python standard library requires it to be 79 characters.
So let's leave it as it is.
In GitLab by @bongjinkoo on Feb 8, 2019, 12:00
closed