SciKit-Surgery/scikit-surgeryutils

Import video_calibration and video_calibration_checker apps from scikit-surgerycalibration.py

Opened this issue · 2 comments

MattClarkson commented
Import video_calibration and video_calibration_checker apps from scikit-surgerycalibration.py
MattClarkson commented

@thompson318 , @tdowrick

Would anyone like to review code on branch 46-use-headless?

In order to use opencv-headless, I had to import videocalibration_app and videocalibrationchecker_app from scikit-surgerycalibration, and then re-write the UI to use PySide (VTKOverlayWindow).

So, its not worth doing a diff with master ... as the 4 main files are a complete re-write.

so, please can someone just look at:

  • sksurgeryutils/ui/sksurgeryvideocalibration_command_line.py
  • sksurgeryutils/ui/sksurgeryvideocalibration_app.py
  • sksurgeryutils/ui/sksurgeryvideocalibrationchecker_command_line.py
  • sksurgeryutils/ui/sksurgeryvideocalibrationchecker_app.py

I also made the decision that things that are static config should be in the config file, and things that you might change on the fly, and hence would not want to git commit, are command line args, e.g. opencv source, interactive mode etc.

Overall, I'm happy with the result, unit tests pass, linting passes, but of course, happy for suggestions.

thompson318 commented

Looks good to me thank you. It only seems to be passing on python 3.7 at the moment. Is that intentional?