BoundsError: attempt to access Float64 at index [2] when `pi` is passed as limit

Question

BoundsError: attempt to access Float64 at index [2] when `pi` is passed as limit

Closed this issue a year ago · 1 comments

Describe the bug 🐞

When pi is passed as the RHS limit for 1D integration, the solver throws
If pi+0 is passed instead, everything works just fine.

Expected behavior

Integrate the function.

Minimal Reproducible Example 👇

Without MRE, we would only be able to help you to a limited extent, and attention to the issue would be limited. to know more about MRE refer to wikipedia and stackoverflow.

using Integrals

TTT=pi+1
solve(IntegralProblem((x, p) -> cos(x), 0.0, TTT), QuadGKJL()).u # fine

YYY=pi
solve(IntegralProblem((x, p) -> cos(x), 0.0, YYY), QuadGKJL()).u # error

Error & Stacktrace ⚠️

ERROR: BoundsError: attempt to access Float64 at index [2]
Stacktrace:
 [1] indexed_iterate(I::Float64, i::Int64, state::Nothing)
   @ Base ./tuple.jl:97
 [2] transformation_if_inf(prob::IntegralProblem{false, Irrational{:π}, IntegralFunction{false, SciMLBase.FullSpecialize, var"#17#18", Nothing}, Float64, Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}}, #unused#::Nothing)
   @ Integrals ~/.julia/packages/Integrals/d5Wr6/src/infinity_handling.jl:118
 [3] init(prob::IntegralProblem{false, Irrational{:π}, IntegralFunction{false, SciMLBase.FullSpecialize, var"#17#18", Nothing}, Float64, Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}}, alg::QuadGKJL{typeof(LinearAlgebra.norm)}; sensealg::Integrals.ReCallVJP{Integrals.ZygoteVJP}, do_inf_transformation::Nothing, kwargs::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
   @ Integrals ~/.julia/packages/Integrals/d5Wr6/src/common.jl:22
 [4] init(prob::IntegralProblem{false, Irrational{:π}, IntegralFunction{false, SciMLBase.FullSpecialize, var"#17#18", Nothing}, Float64, Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}}, alg::QuadGKJL{typeof(LinearAlgebra.norm)})
   @ Integrals ~/.julia/packages/Integrals/d5Wr6/src/common.jl:17
 [5] solve(prob::IntegralProblem{false, Irrational{:π}, IntegralFunction{false, SciMLBase.FullSpecialize, var"#17#18", Nothing}, Float64, Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}}, alg::QuadGKJL{typeof(LinearAlgebra.norm)}; kwargs::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
   @ Integrals ~/.julia/packages/Integrals/d5Wr6/src/common.jl:99
 [6] solve(prob::IntegralProblem{false, Irrational{:π}, IntegralFunction{false, SciMLBase.FullSpecialize, var"#17#18", Nothing}, Float64, Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}}, alg::QuadGKJL{typeof(LinearAlgebra.norm)})
   @ Integrals ~/.julia/packages/Integrals/d5Wr6/src/common.jl:96
 [7] top-level scope
   @ show.jl:1128

Environment (please complete the following information):

Output of using Pkg; Pkg.status()

Status `~/Code/rode_mathieau/Project.toml`
  [0c46a032] DifferentialEquations v7.11.0
  [31c24e10] Distributions v0.25.104
  [f6369f11] ForwardDiff v0.10.36
  [de52edbc] Integrals v4.1.0
  [e7bfaba1] NumericalIntegration v0.3.3
  [7f7a1694] Optimization v3.19.3
  [500b13db] OptimizationPolyalgorithms v0.1.2
  [1ed8b502] SciMLSensitivity v7.48.0
  [44d3d7a6] Weave v0.10.12
  [e88e6eb3] Zygote v0.6.67

Output of using Pkg; Pkg.status(; mode = PKGMODE_MANIFEST)

Status `~/Code/rode_mathieau/Manifest.toml`
  [47edcb42] ADTypes v0.2.5
  [621f4979] AbstractFFTs v1.5.0
  [1520ce14] AbstractTrees v0.4.4
  [79e6a3ab] Adapt v3.7.2
  [ec485272] ArnoldiMethod v0.2.0
  [4fba245c] ArrayInterface v7.6.1
  [4c555306] ArrayLayouts v1.4.4
  [a9b6321e] Atomix v0.1.0
  [13072b0f] AxisAlgorithms v1.0.1
  [aae01518] BandedMatrices v1.3.1
  [62783981] BitTwiddlingConvenienceFunctions v0.1.5
  [764a87c0] BoundaryValueDiffEq v5.5.0
  [fa961155] CEnum v0.5.0
  [2a0fbf3d] CPUSummary v0.2.4
  [49dc2e85] Calculus v0.5.1
  [7057c7e9] Cassette v0.3.12
  [082447d4] ChainRules v1.58.1
  [d360d2e6] ChainRulesCore v1.18.0
  [fb6a15b2] CloseOpenIntervals v0.1.12
  [861a8166] Combinatorics v1.0.2
  [38540f10] CommonSolve v0.2.4
  [bbf7d656] CommonSubexpressions v0.3.0
  [34da2185] Compat v4.10.1
  [2569d6c7] ConcreteStructs v0.2.3
  [88cd18e8] ConsoleProgressMonitor v0.1.2
  [187b0558] ConstructionBase v1.5.4
  [adafc99b] CpuId v0.3.1
  [9a962f9c] DataAPI v1.15.0
  [864edb3b] DataStructures v0.18.15
  [e2d170a0] DataValueInterfaces v1.0.0
  [bcd4f6db] DelayDiffEq v5.44.0
  [8bb1440f] DelimitedFiles v1.9.1
  [2b5f629d] DiffEqBase v6.143.0
  [459566f4] DiffEqCallbacks v2.35.0
  [77a26b50] DiffEqNoiseProcess v5.20.0
  [163ba53b] DiffResults v1.1.0
  [b552c78f] DiffRules v1.15.1
  [0c46a032] DifferentialEquations v7.11.0
  [b4f34e82] Distances v0.10.11
  [31c24e10] Distributions v0.25.104
  [ffbed154] DocStringExtensions v0.9.3
  [fa6b7ba4] DualNumbers v0.6.8
  [da5c29d0] EllipsisNotation v1.8.0
  [4e289a0a] EnumX v1.0.4
  [7da242da] Enzyme v0.11.11
  [f151be2c] EnzymeCore v0.6.4
  [d4d017d3] ExponentialUtilities v1.25.0
  [e2ba6199] ExprTools v0.1.10
  [9d29842c] FastAlmostBandedMatrices v0.1.0
  [7034ab61] FastBroadcast v0.2.8
  [9aa1b823] FastClosures v0.3.2
  [29a986be] FastLapackInterface v2.0.0
  [1a297f60] FillArrays v1.9.3
  [6a86dc24] FiniteDiff v2.21.1
  [f6369f11] ForwardDiff v0.10.36
  [f62d2435] FunctionProperties v0.1.0
  [069b7b12] FunctionWrappers v1.1.3
  [77dc65aa] FunctionWrappersWrappers v0.1.3
  [d9f16b24] Functors v0.4.5
  [0c68f7d7] GPUArrays v9.1.0
  [46192b85] GPUArraysCore v0.1.5
  [61eb1bfa] GPUCompiler v0.25.0
  [c145ed77] GenericSchur v0.5.3
  [86223c79] Graphs v1.9.0
  [19dc6840] HCubature v1.5.1
  [eafb193a] Highlights v0.5.2
  [3e5b6fbb] HostCPUFeatures v0.1.16
  [34004b35] HypergeometricFunctions v0.3.23
  [7869d1d1] IRTools v0.4.11
  [615f187c] IfElse v0.1.1
  [d25df0c9] Inflate v0.1.4
  [de52edbc] Integrals v4.1.0
⌅ [a98d9a8b] Interpolations v0.13.6
  [92d709cd] IrrationalConstants v0.2.2
  [82899510] IteratorInterfaceExtensions v1.0.0
  [692b3bcd] JLLWrappers v1.5.0
  [682c06a0] JSON v0.21.4
  [ccbc3e58] JumpProcesses v9.10.0
  [ef3ab10e] KLU v0.4.1
  [63c18a36] KernelAbstractions v0.9.14
  [ba0b0d4f] Krylov v0.9.5
  [929cbde3] LLVM v6.4.1
  [a5e1c1ea] LatinHypercubeSampling v1.9.0
  [73f95e8e] LatticeRules v0.0.1
  [10f19ff3] LayoutPointers v0.1.15
  [50d2b5c4] Lazy v0.15.1
  [5078a376] LazyArrays v1.8.2
  [1d6d02ad] LeftChildRightSiblingTrees v0.2.0
  [2d8b4e74] LevyArea v1.0.0
  [d3d80556] LineSearches v7.2.0
  [7ed4a6bd] LinearSolve v2.21.0
  [2ab3a3ac] LogExpFunctions v0.3.26
  [e6f89c97] LoggingExtras v1.0.3
  [bdcacae8] LoopVectorization v0.12.166
  [1914dd2f] MacroTools v0.5.11
  [d125e4d3] ManualMemory v0.1.8
  [a3b82374] MatrixFactorizations v2.1.0
  [e1d29d7a] Missings v1.1.0
  [4886b29c] MonteCarloIntegration v0.1.2
  [46d2c3a1] MuladdMacro v0.2.4
  [ffc61752] Mustache v1.0.19
  [d41bc354] NLSolversBase v7.8.3
  [2774e3e8] NLsolve v4.5.1
  [872c559c] NNlib v0.9.8
  [77ba4419] NaNMath v1.0.2
⌅ [8913a72c] NonlinearSolve v2.8.2
  [e7bfaba1] NumericalIntegration v0.3.3
  [d8793406] ObjectFile v0.4.1
  [6fe1bfb0] OffsetArrays v1.12.10
  [429524aa] Optim v1.7.8
  [3bd65402] Optimisers v0.3.1
  [7f7a1694] Optimization v3.19.3
  [36348300] OptimizationOptimJL v0.1.14
  [42dfb2eb] OptimizationOptimisers v0.1.6
  [500b13db] OptimizationPolyalgorithms v0.1.2
  [bac558e1] OrderedCollections v1.6.3
⌃ [1dea7af3] OrdinaryDiffEq v6.59.3
  [90014a1f] PDMats v0.11.31
  [65ce6f38] PackageExtensionCompat v1.0.2
  [d96e819e] Parameters v0.12.3
  [69de0a69] Parsers v2.8.0
  [e409e4f3] PoissonRandom v0.4.4
  [f517fe37] Polyester v0.7.9
  [1d0040c9] PolyesterWeave v0.2.1
  [85a6dd25] PositiveFactorizations v0.2.4
  [d236fae5] PreallocationTools v0.4.13
  [aea7be01] PrecompileTools v1.2.0
  [21216c6a] Preferences v1.4.1
  [33c8b6b6] ProgressLogging v0.1.4
  [92933f4c] ProgressMeter v1.9.0
  [1fd47b50] QuadGK v2.9.1
⌅ [8a4e6c94] QuasiMonteCarlo v0.2.9
  [74087812] Random123 v1.6.1
  [e6cf234a] RandomNumbers v1.5.3
  [c84ed2f1] Ratios v0.4.5
  [c1ae055f] RealDot v0.1.0
  [3cdcf5f2] RecipesBase v1.3.4
⌅ [731186ca] RecursiveArrayTools v2.38.10
  [f2c3362d] RecursiveFactorization v0.2.21
  [189a3867] Reexport v1.2.2
  [05181044] RelocatableFolders v1.0.1
  [ae029012] Requires v1.3.0
  [ae5879a3] ResettableStacks v1.1.1
  [37e2e3b7] ReverseDiff v1.15.1
  [79098fc4] Rmath v0.7.1
  [7e49a35a] RuntimeGeneratedFunctions v0.5.12
  [94e857df] SIMDTypes v0.1.0
  [476501e8] SLEEFPirates v0.6.42
⌃ [0bca4576] SciMLBase v2.10.0
  [e9a6253c] SciMLNLSolve v0.1.9
  [c0aeaf25] SciMLOperators v0.3.7
  [1ed8b502] SciMLSensitivity v7.48.0
  [6c6a2e73] Scratch v1.2.1
  [efcf1570] Setfield v1.1.1
⌅ [727e6d20] SimpleNonlinearSolve v0.1.25
  [699a6c99] SimpleTraits v0.9.4
  [ce78b400] SimpleUnPack v1.1.0
  [ed01d8cd] Sobol v1.5.0
  [a2af1166] SortingAlgorithms v1.2.0
  [47a9eef4] SparseDiffTools v2.14.0
  [dc90abb0] SparseInverseSubset v0.1.1
  [e56a9233] Sparspak v0.3.9
  [276daf66] SpecialFunctions v2.3.1
  [860ef19b] StableRNGs v1.0.1
  [aedffcd0] Static v0.8.8
  [0d7ed370] StaticArrayInterface v1.5.0
  [90137ffa] StaticArrays v1.7.0
  [1e83bf80] StaticArraysCore v1.4.2
  [82ae8749] StatsAPI v1.7.0
  [2913bbd2] StatsBase v0.34.2
  [4c63d2b9] StatsFuns v1.3.0
⌅ [9672c7b4] SteadyStateDiffEq v1.16.1
  [789caeaf] StochasticDiffEq v6.64.0
  [7792a7ef] StrideArraysCore v0.5.2
  [69024149] StringEncodings v0.3.7
  [09ab397b] StructArrays v0.6.16
  [53d494c1] StructIO v0.3.0
  [c3572dad] Sundials v4.22.1
⌅ [2efcf032] SymbolicIndexingInterface v0.2.2
  [3783bdb8] TableTraits v1.0.1
  [bd369af6] Tables v1.11.1
  [5d786b92] TerminalLoggers v0.1.7
  [8290d209] ThreadingUtilities v0.5.2
  [a759f4b9] TimerOutputs v0.5.23
  [9f7883ad] Tracker v0.2.30
  [d5829a12] TriangularSolve v0.1.20
  [410a4b4d] Tricks v0.1.8
  [781d530d] TruncatedStacktraces v1.4.0
  [3a884ed6] UnPack v1.0.2
  [013be700] UnsafeAtomics v0.2.1
  [d80eeb9a] UnsafeAtomicsLLVM v0.1.3
  [3d5dd08c] VectorizationBase v0.21.65
  [19fa3120] VertexSafeGraphs v0.2.0
  [44d3d7a6] Weave v0.10.12
  [efce3f68] WoodburyMatrices v0.5.6
  [ddb6d928] YAML v0.4.9
  [e88e6eb3] Zygote v0.6.67
  [700de1a5] ZygoteRules v0.2.4
  [7cc45869] Enzyme_jll v0.0.96+0
  [1d5cc7b8] IntelOpenMP_jll v2024.0.0+0
  [dad2f222] LLVMExtra_jll v0.0.27+1
  [94ce4f54] Libiconv_jll v1.17.0+0
  [856f044c] MKL_jll v2024.0.0+0
  [efe28fd5] OpenSpecFun_jll v0.5.5+0
  [f50d1b31] Rmath_jll v0.4.0+0
⌅ [fb77eaff] Sundials_jll v5.2.1+0
  [0dad84c5] ArgTools v1.1.1
  [56f22d72] Artifacts
  [2a0f44e3] Base64
  [ade2ca70] Dates
  [8ba89e20] Distributed
  [f43a241f] Downloads v1.6.0
  [7b1f6079] FileWatching
  [9fa8497b] Future
  [b77e0a4c] InteractiveUtils
  [4af54fe1] LazyArtifacts
  [b27032c2] LibCURL v0.6.4
  [76f85450] LibGit2
  [8f399da3] Libdl
  [37e2e46d] LinearAlgebra
  [56ddb016] Logging
  [d6f4376e] Markdown
  [a63ad114] Mmap
  [ca575930] NetworkOptions v1.2.0
  [44cfe95a] Pkg v1.9.2
  [de0858da] Printf
  [3fa0cd96] REPL
  [9a3f8284] Random
  [ea8e919c] SHA v0.7.0
  [9e88b42a] Serialization
  [1a1011a3] SharedArrays
  [6462fe0b] Sockets
  [2f01184e] SparseArrays
  [10745b16] Statistics v1.9.0
  [4607b0f0] SuiteSparse
  [fa267f1f] TOML v1.0.3
  [a4e569a6] Tar v1.10.0
  [8dfed614] Test
  [cf7118a7] UUIDs
  [4ec0a83e] Unicode
  [e66e0078] CompilerSupportLibraries_jll v1.0.5+0
  [deac9b47] LibCURL_jll v8.4.0+0
  [29816b5a] LibSSH2_jll v1.11.0+1
  [c8ffd9c3] MbedTLS_jll v2.28.2+0
  [14a3606d] MozillaCACerts_jll v2022.10.11
  [4536629a] OpenBLAS_jll v0.3.21+4
  [05823500] OpenLibm_jll v0.8.1+0
  [bea87d4a] SuiteSparse_jll v5.10.1+6
  [83775a58] Zlib_jll v1.2.13+0
  [8e850b90] libblastrampoline_jll v5.8.0+0
  [8e850ede] nghttp2_jll v1.52.0+1
  [3f19e933] p7zip_jll v17.4.0+0
Info Packages marked with ⌃ and ⌅ have new versions available. Those with ⌃ may be upgradable, but those with ⌅ are restricted by compatibility constraints from upgrading. To see why use `status --outdated -m`

Output of versioninfo()

Julia Version 1.9.4
Commit 8e5136fa297 (2023-11-14 08:46 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: macOS (x86_64-apple-darwin22.4.0)
  CPU: 8 × Intel(R) Core(TM) i5-8279U CPU @ 2.40GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, skylake)
  Threads: 8 on 8 virtual cores
Environment:
  JULIA_EDITOR = code

Additional context

Add any other context about the problem here.

Answer 1 · 2023-12-14T13:31:19.000Z

We should just promote irrational to float at problem construction.