Non type-safe units

Question

Non type-safe units

Opened this issue 4 years ago · 11 comments

CommanderTvis commented 4 years ago

(unit = "m", value = 42.0) / (unit = "s", value = 2.0) = (unit = ("/", "m", "s"), value = 21.0)

Values with a unit can be implemented as pair of MST of the special context and unit.

Possible benefits: valid unit shape, concise implementation.
Possible problem: lack of simplification of the shape.

Answer 1 · 2021-02-27T16:40:05.000Z

cc @altavir @Shimuuar @pusolito @green-nick @pedroteixeira from #75

Answer 2 · 2021-02-27T16:41:15.000Z

Prototype: https://github.com/mipt-npm/kmath/blob/commandertvis/units-poc/kmath-units/src/commonMain/kotlin/space/kscience/kmath/units/units.kt

Answer 3 · 2021-02-27T17:19:17.000Z

MST-based units require additional considerations. On one hand, they are not compile-time type-safe, so they do not make sense in this regard. On the other hand, the context used to generate those units could provide runtime type unit check. Also with a staged compilation like one available in jupyter, it could be beneficial.

Answer 4 · 2021-02-27T17:45:30.000Z

I think the main problem is that N*m ≠ m*N etc.

Answer 5 · 2021-02-27T18:33:55.000Z

MST does not state that binary operation should be commutative. On the contrary, I would not expect that.

Answer 6 · 2021-02-27T18:43:27.000Z

I mean units are not simplified to a certain comparable form

Answer 7 · 2021-02-27T18:44:23.000Z

However, it is not such hard to implement such an algorithm - it is much easier than simplify a plain expression.

Answer 8 · 2021-02-28T00:08:09.000Z

Did the Measured lib prove useful? This was discussed as a possible path in #75.

Answer 9 · 2021-02-28T06:03:30.000Z

This issue is not about user level api. It is about generalization of symbolic processing of units. Measured is a nice way to use units and we do not want to dublicate it.

Answer 10 · 2021-02-28T07:41:42.000Z

I've reworked the prototype without MST - units are stored as a product of base units.

import space.kscience.kmath.operations.RealField
import space.kscience.kmath.units.*

public fun main() {
    var res = with(MeasurementExtendedField(RealField)) {
        val a = (2.0 * kg) / (3.0 * m) / (2.0 * with(MeasureAlgebra) { s * s })
        val b = (23.0 * Pa)
        a + b
    }

    println(res)

    res = with(MeasurementExtendedField(RealField)) {
        val a = (2.0 * G(m)) + (3.0 * M(m))
        val b = (3.0 * au)
        a + b
    }

    println(res)
}

Measurement(measure=Measure(chain={SECOND=-2, METER=-1, KILOGRAM=1}, multiplier=1.0), value=23.333333333333332)
Measurement(measure=Measure(chain={METER=1}, multiplier=1.0), value=4.507966121E11)

Process finished with exit code 0

Answer 11 · 2021-02-28T07:42:53.000Z

Actually, it is a dynamic analogue of Measured API.