cortx-prvsnr submodule in cortx is pointing to pre-cortx-1.0 branch instead of main branch

Question

cortx-prvsnr submodule in cortx is pointing to pre-cortx-1.0 branch instead of main branch

Closed this issue 3 years ago · 13 comments

We have submodules configured for all component repositories in cortx repo. All other components are configured for main branch however for cortx-prvsnr it's pre-cortx-1,0 branch.

This may be because pre-cortx-1,0 is default branch for cortx-prvsnr repository.

Answer 1 · 2021-03-23T15:43:25.000Z

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @shailesh-vaidya for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

Answer 2 · 2021-05-28T05:56:41.000Z

@mukul-seagate11 Can we finalize on this.

Answer 3 · 2021-05-28T10:36:12.000Z

@ypise, what decision are we planning for the provisioner landing branch as some action has to be taken to switch the same to main branch as its accessible to external community?

Answer 4 · 2021-06-10T06:52:08.000Z

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @shailesh-vaidya for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

Answer 5 · 2021-06-10T12:54:49.000Z

@mukul-seagate11 , @shailesh-vaidya
The submodule in cortx repo needs to be updated to point to the main branch of cortx-prvsnr.
It's not related to setting in cortx-prvsnr in GitHub.

Answer 6 · 2021-06-11T05:46:14.000Z

@ypise, as currently the submodule for cortx-prvsnr is pointing to pre-cortx-1.0 branch as https://github.com/Seagate/cortx-prvsnr/blob/pre-cortx-1.0/.github/workflows/dispatch_submodule_update.yml
where it should point to the default branch i.e. main

Answer 7 · 2021-06-11T13:59:28.000Z

@mukul-seagate11
It is main branch as configured in the link mentioned above. main being our actual landing branch, this configuration should hold good.

Answer 8 · 2021-06-14T05:13:37.000Z

@shailesh-vaidya, can you comment on the same as seems our expectation is different as stated in thread?

Answer 9 · 2021-06-14T06:42:19.000Z

@mukul-seagate11 If provisioner is using pre-cortx-1.0 as validation and main is landing branch then we need to debug and modify submodule configuration for cortx repo to sync main branch codebase.
e.g. Currently cortx-prvsnr main branch is at - 76c6303f86802c6cda7fe407955e71a4d86f02e6
and cortx repo provisioner submodule is poiting to - https://github.com/Seagate/cortx-prvsnr/tree/873969f4fc798e8e2009c60e586a203d49dc3c15

Answer 10 · 2021-06-14T10:03:35.000Z

@gauravchaudhari02, can you look & correct accordingly for provisioner wokflow?

Answer 11 · 2021-06-21T11:21:09.000Z

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @shailesh-vaidya for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

Answer 12 · 2021-12-08T21:53:55.000Z

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @shailesh-vaidya for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

Answer 13 · 2021-12-10T11:30:57.000Z

This issue is fixed now.