Don't include uncommitted config changes
Closed this issue · 1 comments
Deleted user commented
Right now, cjdns.uci.get() includes uncommitted config changes. Instead, only stuff that's committed should be included.
Expected:
$ s=$(uci add cjdns password); uci set cjdns.$s.password=12345
$ cat /etc/config/cjdns | grep 12345
$ cjdrouteconf get | grep 12345
$ uci commit
$ cjdrouteconf get | grep 12345
"password":"12345",
$ cat /etc/config/cjdns | grep 12345
option password '12345'
Actual:
$ s=$(uci add cjdns password); uci set cjdns.$s.password=12345
$ cat /etc/config/cjdns | grep 12345
$ cjdrouteconf get | grep 12345
"password":"12345",
$ uci commit
$ cjdrouteconf get | grep 12345
"password":"12345",
$ cat /etc/config/cjdns | grep 12345
option password '12345'
Deleted user commented
This is actually just how UCI is supposed to worked.
1 - Make change, reload config
2 - Test change
3a - Commit change
3b - Revert change, reload config
Everything is good.