Should be added to F-droid.org repository.

Question

Should be added to F-droid.org repository.

gohanko opened this issue 6 years ago · 12 comments

I actually thought that this app is a commercial, closed source app. It didn't say that it is a open-source app on Google Play either. I think it would be a great addition to the F-droid open source repository.

Answer 1 · 2018-06-02T19:57:43.000Z

this app requires google play services. That may be a problem for fdroid inclusion. See:
https://f-droid.org/en/docs/Inclusion_Policy/

However, I believe I can fork this and take out the google play dependancy and have the rest of the app work. I'll see what I can do.

Answer 2 · 2018-06-07T11:11:47.000Z

@anjandev Removing the Google Play dependency should be quite easy. Let me know if you encounter any issues.

Personally I do not want to support support multiple stores with different APK's. Closing this issue.

Answer 3 · 2018-11-04T16:09:12.000Z

Seems like @anjandev never tried... I try right now and encounter following issue.
I cannot remove com.google.android.gms:play-services-cast-framework:16.0.2 because than androidx.mediarouter:mediarouter is not available anymore.

The second issue, com.sebastianrask.bettersubscription.misc.SecretKeys is missing. Can you provide a template file what data is in it?

Answer 4 · 2018-11-05T03:19:40.000Z

@Perflyst It's a bit more complex. You also have to remove the telemetry. I have it on my computer I just havent pushed anything cause I didnt get it to work.

Thanks for looking into it.

Answer 5 · 2018-11-05T05:26:02.000Z

I did removed the tracking and "google" code from the app. Also firebase and crashlytics is gone. What do you mean with "remove telemetry"? Can you push it in a dev branch so that I can take a look?

…

On November 5, 2018 3:19:41 AM UTC, Anjan Momi ***@***.***> wrote: @Perflyst It's a bit more complex. You also have to remove the telemetry. I have it on my computer I just havent pushed anything cause I didnt get it to work. Thanks for looking into it. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #1 (comment)

Answer 6 · 2019-03-17T18:28:38.000Z

@SebastianRask would you please provide support on this?
I do not understand why do you have implemented google librarys. This app was a learning project and you probably created it for the use of yourself.
So you implemented Google just to track you in your own app?

What does the (tracking) google libs do in the app? Are they really needed?

Answer 7 · 2019-03-17T18:38:12.000Z

@Perflyst When publishing the app to Google Play i added a few Google Analytics events to understand how people used the app and how many people dropped off during the onboarding and donation flow.

That is all it does.

I imagine the hard part is removing the casting support as it is a tightly coupled with the rest of the streaming and ui logic

Answer 8 · 2019-03-17T18:44:02.000Z

Okay. Thanks, but still.. sad. This is the only app which is working great and has a very nice UI. There is no similar app available and also there is no Twitch client on f-droid (okay there is one but it is very old and needs vlc app too)

Answer 9 · 2019-03-17T18:51:42.000Z

@Perflyst With a bit of work, I am sure it can be done.

Answer 10 · 2019-03-17T19:00:09.000Z

Also @SebastianRask , it doesn't mean you need to maintain it. Maybe we could fork it, do some work and then push it upstream but maintain the downstream version for F-Droid.

Answer 11 · 2019-03-25T18:53:18.000Z

https://gitlab.com/fdroid/fdroiddata/merge_requests/4662

--

You will not have any Twitch Chat if you don't log in but everything else works. I removed unused stuff and also dropped some permissions.

Answer 12 · 2019-12-12T22:58:50.000Z

Even though this issue has been closed for some time, I posting this for everyone who comes across it in the future:
Someone forked this and made it completely FOSS
https://github.com/Perflyst/Twire
And it is also on F-droid
https://f-droid.org/en/packages/com.perflyst.twire/