Securing-DevOps/invoicer-chapter2

Grabbing linux-docker which is too new for configuration file.

Closed this issue · 3 comments

AWS has evolved. This grep will now the pull the latest version of the docker linux. This is incompatible with the app-version.json file supplied because it complains that this value needs to be 2
"AWSEBDockerrunVersion": "1",

I suggest changing this code:

jq -r '.SolutionStacks[]' | grep -P '.+Amazon Linux.+Docker.+' | head -1)"

to this:

jq -r '.SolutionStacks[]' | grep -P '.+Amazon Linux.+Docker.+v2\.7.+' | head -1)"

Or maybe we could keep the grep as it is, and bump app-version.json to version 2?

That would be recommended if you want to continue to maintain this repo. i.e. if it were a real project.

The grep update relieves you of the obligation to watch for changes in AWS, while providing a repo that your readers can use without breaking. i.e. Are you going to notice, and update, this repo when a new version of docker requires a new version of the app-version?

fixed in f2678d0