Sentaroh/SMBSync2

Pull request: complete schedule fixes

Closed this issue · 1 comments

Pull request: #188

I completed my previous patch after your merge.
I am done with that part

Changes:

  • translation fr:
    • shorten some messages to fit the screen if needed because the max allowed error lines is 3 (Fr/eng)
  • remove now unused messages
  • do not show the schedule button when schedule list is empty + ensure NPE handling
  • add missing space between Edit Schedule title and Schedule name in the EditSchedule dialog
  • translate the new created schedule name
  • if all auto-generated schedule names exist (>1000), do not rely on xml layout text field but on the translated new name message: this avoids a NPE if the layout text is removed in some code maintenance
  • never modify the edited schedule name even if it is empty: do not change the schedule and throw an error message so user can rename it
  • if an edited schedule has a null name (settings file corruption), notify the error
  • add a few NPE checks also when renaming sync tasks and schedules

Thank you and best regards

Sorry, I again forgot a small check in copy/paste the code
Fixed properly now in #190

Best regards