Sertion/vscode-gitblame

"Will not blame X, Outside the current workspace."

YaroST12 opened this issue · 3 comments

Hello there,

Due to an annoying bug related to git gutters in vscode (microsoft/vscode#176497) I have to use a workaround, which sets --git-dir argument to the actual directory of the .git folder...

... which causes git blame to think that all files are outside its current workspace.
The workaround in question can be found here: https://stackoverflow.com/questions/75615136/vscode-vscodium-showing-git-gutters-even-though-there-are-no-actual-changes-in-t

Is there anything I can modify in the workaround script or in the extention itself to make them work well together? Thanks.

I've updated my script to work nicely with both vscode and git blame extension, but I may have an idea as to why this extension started misbehaving:
perhaps it makes more sense to parse --work-tree here instead of --git-dir: https://github.com/Sertion/vscode-gitblame/blob/main/src/git/util/gitcommand.ts#L71-L72

General Furman.

I am not exactly sure what I can do here.

I've found some places in the extension where we assume that the git path and the file path has overlap and I'm working on changing them to be more generic. Other than that the modified script looks like it should work. The extension uses the vscode.git built-in extension to get the path to the git executable (permanent link).

Perhaps this was the issue you where running into?

Hi, the modified script works. Waiting for VSCode to get fixed :(