RequestLogFilter is not invoked by CsvRequestLogger
Closed this issue · 1 comments
Describe the issue
CsvRequestLogger overrides the Log method but does not perform a RequestLogFilter.Invoke after CreateEntry like base.Log does.
Reproduction
Add a RequestLogsFeature with RequestLogger set to a CsvRequestLogger.
Set the RequestLogFilter to something, e.g:
RequestLogFilter = (request, entry) => Console.WriteLine ("foo")
Run the service and send a request that triggers logging, note that the above action is never performed. No "foo".
Try letting RequestLogger default to an InMemoryRollingRequestLogger, and perform the same test.
The action is now invoked and "foo" is output.
Expected behavior
Expected same behavior regardless of RequestLogger implementation, i.e. "foo" is output.
System Info
ServiceStack.Core 6.2.0Additional context
Likely fixed by adding RequestLogFilter?.Invoke(request, entry); after CreateEntry on line 150 in CsvRequestLogger.
Validations
- Confirm Issue is reproducible from the information provided
- Have an active commercial ServiceStack License (GitHub Username is registered on Support page)
This should now be fixed from v6.2.1+ that's now available on MyGet.
thx for reporting!