Seshat-Global-History-Databank/seshat

🐛 [BUG] - Map pages Javascript changes get ignored in preference for cached version

Closed this issue · 1 comments

edwardchalstrey1 commented

Description

If there are any updates to https://github.com/Seshat-Global-History-Databank/seshat/blob/dev/seshat/apps/core/static/core/js/map_functions.js pushed to the website, even after running python manage.py collectstatic you may currently need to hard refresh the browser to see the updates and errors can be thrown if functions work differently.

Find a way to avoid this.

Reproduction steps

1. Go to e.g. seshatdata.com
2. Make a change to that JS
3. python manage.py collectstatic
4. Go to maps pages and inspect JS used

Screenshots

No response

Logs

No response

Browsers

Chrome

OS

No response

Definition of Done

  • A fix for the bug has been developed on a branch.
  • The bug fix branch has been tested in the Staging website.
  • A pull request has been created for the new branch to be merged into the dev branch.
edwardchalstrey1 commented

One option could be to simply move the map_functions.js as I'm not sure this should live in static anyway