API Keys
JohnMH opened this issue · 25 comments
Your current code has API keys for services used, you should either remove all such items and services. This application is infringing on the rights of users. People want to be able to freely look up a term in a dictionary of their language. The best way to do this is to use the dictionaries already present on the system.
Do not use services that log requests made by users, and, certainly, not with your API keys. Your users are not you.
infringing on the rights of users
Every user has the right to use any type of software they wish. While I respect your personal view on the matter. This is only a personal view. Your concerns tho will be taken into consideration in futher development. But at this time things work fine.
Your welcome to fork the project and do this yourself however. Pull requests are welcomed.
You missed the entire point of the issue, the issue is that he uses his personal API keys in this application.
@JohnMHarrisJr LOL! As if that matters! Please learn, you fool!
For an application created to define words, using another individual's
personal key is a serious issue. The proper way to go about this would
be to install a dictionary.
On 09/12/2015 04:59 PM, William Maduno | Diitto wrote:
@JohnMHarrisJr https://github.com/JohnMHarrisJr LOL! As if that
matters! Please learn, you fool!—
Reply to this email directly or view it on GitHub
#16 (comment).
Then do it yourself, silly! Are you not a developer? Or just too crappy of
one? If you don't feel like it, then don't make complaints, imbecile! :D
On Saturday, September 12, 2015, John M. Harris, Jr. <
notifications@github.com> wrote:
For an application created to define words, using another individual's
personal key is a serious issue. The proper way to go about this would
be to install a dictionary.On 09/12/2015 04:59 PM, William Maduno | Diitto wrote:
@JohnMHarrisJr https://github.com/JohnMHarrisJr LOL! As if that
matters! Please learn, you fool!—
Reply to this email directly or view it on GitHub
#16 (comment).—
Reply to this email directly or view it on GitHub
#16 (comment).
- William Maduno | Diitto
@JohnMHarrisJr
"Define is a terminal dictionary script that uses wordnik for definitions"
Changing an API key would make no difference since wordnik would still give English definitions. Not providing an API key would provide nothing but inconvenience
This is no complaint, this is an issue. This is not something that
effects only me, this effects all users of this program.
On 09/12/2015 05:03 PM, William Maduno | Diitto wrote:
Then do it yourself, silly! Are you not a developer? Or just too crappy of
one? If you don't feel like it, then don't make complaints, imbecile! :DOn Saturday, September 12, 2015, John M. Harris, Jr. <
notifications@github.com> wrote:For an application created to define words, using another individual's
personal key is a serious issue. The proper way to go about this would
be to install a dictionary.On 09/12/2015 04:59 PM, William Maduno | Diitto wrote:
@JohnMHarrisJr https://github.com/JohnMHarrisJr LOL! As if that
matters! Please learn, you fool!—
Reply to this email directly or view it on GitHub—
Reply to this email directly or view it on GitHub
#16 (comment).
- William Maduno | Diitto
—
Reply to this email directly or view it on GitHub
#16 (comment).
Then, perhaps, you shouldn't use wordnik. You should either find another
service, or simply install a dictionary of your own.
On 09/12/2015 05:03 PM, SethDusek wrote:
"Define is a terminal dictionary script that uses wordnik for definitions"
Changing an API key would make no difference since wordnik would still
give english definitions. Not providing an API key would provide
nothing but inconvenience—
Reply to this email directly or view it on GitHub
#16 (comment).
Well, then. Go find some other program to use. It's not as if you have to
use define, and it's not like the other users of define care about your
ideals. You have no reason to care for the other users of define, either.
On Saturday, September 12, 2015, John M. Harris, Jr. <
notifications@github.com> wrote:
This is no complaint, this is an issue. This is not something that
effects only me, this effects all users of this program.On 09/12/2015 05:03 PM, William Maduno | Diitto wrote:
Then do it yourself, silly! Are you not a developer? Or just too crappy
of
one? If you don't feel like it, then don't make complaints, imbecile! :DOn Saturday, September 12, 2015, John M. Harris, Jr. <
notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:For an application created to define words, using another individual's
personal key is a serious issue. The proper way to go about this would
be to install a dictionary.On 09/12/2015 04:59 PM, William Maduno | Diitto wrote:
@JohnMHarrisJr https://github.com/JohnMHarrisJr LOL! As if that
matters! Please learn, you fool!—
Reply to this email directly or view it on GitHub—
Reply to this email directly or view it on GitHub
<#16 (comment)
.
- William Maduno | Diitto
—
Reply to this email directly or view it on GitHub
#16 (comment).—
Reply to this email directly or view it on GitHub
#16 (comment).
- William Maduno | Diitto
Note that it would only require changing only one variable to change the
API key. If users don't want to use @SethDusek's API key, so be it. It's
not like this is proprietary software with the API key hard wired into the
program.
On Saturday, September 12, 2015, John M. Harris, Jr. <
notifications@github.com> wrote:
Then, perhaps, you shouldn't use wordnik. You should either find another
service, or simply install a dictionary of your own.On 09/12/2015 05:03 PM, SethDusek wrote:
"Define is a terminal dictionary script that uses wordnik for
definitions"Changing an API key would make no difference since wordnik would still
give english definitions. Not providing an API key would provide
nothing but inconvenience—
Reply to this email directly or view it on GitHub
#16 (comment).—
Reply to this email directly or view it on GitHub
#16 (comment).
- William Maduno | Diitto
I do not personally use "define", but this is an issue, and it is valid.
It was closed, because the developers are to narrow minded to accept
that this project is, currently, failing to provide a basic dictionary
to users. It would, currently, be more helpful to download the entirety
of Websters English Dictionary to my disk, than to install this Python
script.
On 09/12/2015 08:06 PM, William Maduno | Diitto wrote:
Well, then. Go find some other program to use. It's not as if you have to
use define, and it's not like the other users of define care about your
ideals. You have no reason to care for the other users of define, either.On Saturday, September 12, 2015, John M. Harris, Jr. <
notifications@github.com> wrote:This is no complaint, this is an issue. This is not something that
effects only me, this effects all users of this program.On 09/12/2015 05:03 PM, William Maduno | Diitto wrote:
Then do it yourself, silly! Are you not a developer? Or just too
crappy
of
one? If you don't feel like it, then don't make complaints,
imbecile! :DOn Saturday, September 12, 2015, John M. Harris, Jr. <
notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:For an application created to define words, using another
individual's
personal key is a serious issue. The proper way to go about this
would
be to install a dictionary.On 09/12/2015 04:59 PM, William Maduno | Diitto wrote:
@JohnMHarrisJr https://github.com/JohnMHarrisJr LOL! As if that
matters! Please learn, you fool!—
Reply to this email directly or view it on GitHub—
Reply to this email directly or view it on GitHub
- William Maduno | Diitto
—
Reply to this email directly or view it on GitHub—
Reply to this email directly or view it on GitHub
#16 (comment).
- William Maduno | Diitto
—
Reply to this email directly or view it on GitHub
#16 (comment).
@JohnMHarrisJr It's nice you have an opinon, but it's just your own personal views here. As you do not even use define, this subject shouldn't even apply to you. I will however suggest you go buy a dictionary at your local bookshop. Since api keys and privacy is so important to you.
While the type of program define is does not match up with your ideals, it doesn't make that the case for everyone. Respect others freedom and stop with these posts.
@JohnMharrisJr Yep it sure would be. Let's see what would happen if I run
cat dict.txt | grep test
https://gist.github.com/SethDusek/1db141491bdd74063b73
I would use dict but it returns loads and loads of (sometimes irrelevant) definitions, and the manpages do not seem to mention how one could limit the definitions.
https://gist.github.com/SethDusek/fa5a14cb873cc5a28e02
The answer seems quite obvious, it's simple text parsing. I suggest you
make a new branch of define, and give this a try. :)
On 09/13/2015 12:19 PM, SethDusek wrote:
@JohnMharrisJr https://github.com/JohnMharrisJr Yep it sure would
be. Let's see what would happen if I runcat dict.txt | grep testhttps://gist.github.com/SethDusek/1db141491bdd74063b73
I would use dict but it returns loads and loads of (sometimes
irrelevant) definitions, and the manpages do not seem to mention how
one could limit the definitions.
https://gist.github.com/SethDusek/fa5a14cb873cc5a28e02—
Reply to this email directly or view it on GitHub
#16 (comment).
Maybe, but it most likely won't be the primary dictionary, maybe a fallback + a flag to use it
It should be the default, and there should be multiple dictionaries (for
every language supported). If you need audio, you can synthesize using
GNUstep or similar software.
On 09/13/2015 12:34 PM, SethDusek wrote:
Maybe, but it most likely won't be the primary dictionary, maybe a
fallback + a flag to use it—
Reply to this email directly or view it on GitHub
#16 (comment).
Just to update on this, define can parse the gcide dictionary for the DICT protocol, and also has support for WordNet, both using http (by the textblob module) and locally (using the wn program). If the local flag is set, it will use espeak for audio instead of downloading from wordnik.
There should be no network requests, for any part of this software other
than Urban Dictionary "definitions."
On 10/02/2015 01:31 PM, SethDusek wrote:
Just to update on this, define can parse the gcide dictionary for the
DICT protocol, and also has support for WordNet, both using http (by
the textblob module) and locally (using the wn program). If the local
flag is set, it will use espeak for audio instead of downloading from
wordnik.—
Reply to this email directly or view it on GitHub
#16 (comment).
No, they will stay. Wordnik will stay, bighugelabs thesaurus will stay and so will urban dictionary
There is no use for Wordnik, you've already included a proper dictionary.
On 10/03/2015 04:15 AM, SethDusek wrote:
No, they will stay. Wordnik will stay, bighugelabs thesaurus will stay
and so will urban dictionary—
Reply to this email directly or view it on GitHub
#16 (comment).
No, wordnik has more detailed definitions compared to wordnet. In the future there will be a config file though that will let you select default dictionary
You should be using neither "wordnick" nor "wordnet", but dictionary
files that you download to the client's computer with your application,
or separately as libraries.
On 10/03/2015 03:51 PM, SethDusek wrote:
No, wordnik has more detailed definitions compared to wordnet. In the
future there will be a config file though that will let you select
default dictionary—
Reply to this email directly or view it on GitHub
#16 (comment).
WordNet can be local or using http. If you have the textblob python module installed, it will use http. If it detects the wn (WordNet) program, it will use that instead, which is local.
Parsing local dictionaries is a pain as each outputs differently
It should use neither, it should parse a dictionary file that you create
for this program specifically, or following some standard that I,
obviously, don't know about. Perhaps, just StarDict format.
On 10/04/2015 02:55 AM, SethDusek wrote:
WordNet can be local or using http. If you have the textblob python
module installed, it will use http. If it detects the wn (WordNet)
program, it will use that instead, which is local.Parsing local dictionaries is a pain in the ass as each outputs
differently—
Reply to this email directly or view it on GitHub
#16 (comment).
I'm locking this since you're incredibly dense and still think that wordnik spies on you. They have no reason to, and I even talked to the developer about it. And even if they did, what words do you search that you feel uncomfortable sharing?