Can't seem to install any version of this plugin in sylius 1.8 or 1.9
acornforth opened this issue · 11 comments
We are in the process of upgrading our sylius store from 1.8 to 1.9, our 1.8 branch is running on symfony 4.4, our 1.9 branch is running symfony 5.2.
Unfortunately I have not been able to install this plugin in either branch because the dependencies can't be resolved.
I started looking through the history of composer.json for th plugin and it seems that the dependencies have changes quite drastically between tagged releases, and it's not obvious which versions of sylius the plugin targets... some of the deps seem too new for S1.8 but then if i try to install it on S1.9, requires a lower version (^2.8) of the REST Bundle(v3.0.5) than our store (Sylius1.9.6)
+1 Same problem here.
Sylius 1.9+ require "friendsofsymfony/rest-bundle" ^3.0 but your requirments specify only ^2.8
Your requirments seems to be too strict. You should just support from a specific version of Sylius and inherit from Sylius requirments.
Thx ;-)
I think that for Sylius 1.9, you should use 0.12.x that is not yet tagged as a release as it is a WIP. But what's the problem for 1.8 @acornforth ?
I tried with -W flag, but it wanted to upgrade a whole bunch of symfony and sylius packages.
I also tried just upgrading the knp-menu package, but then the next time, i jsut get a different package blocking the upgrade
I second @laurentdabbb's comment. Event on 0.12.x-dev, the requirements seems too strict.
Few points that could be discussed :
- sylius/sylius is in dev requirements while the Plugin Skeleton use it as a non-dev requirement
- setono/sylius-catalog-promotion-plugin is required as a dev dependency, why ?
- some requirements (and dev requirements) are actually sylius/sylius requirements that could be delegated to sylius/sylius
Are there any reasons behind those choices (mainly the "not inheriting from sylius/sylius" part) ? Are we missing something here ?
Thanks !
@acornforth: Could you try and use the 0.12.x branch for 1.9 as @Roshyo suggests and give me a status?
Hi @loevgaard
Sorry i haven't had a chance to test this for a while, my attention has been needed elsewhere.
We still haven't got our main branch on to sylius 1.9 yet, we need to get some other features merged and do a big rebase before we get there, so here are the attempts i made on each branch.
Attempt on our sylius 1.9 branch:
and on our 1.8 branch.
My first attempts to install were part of my initial research into whether this plugin is a viable option for us. And i think it could be, but meanwhile i have been tasked with some other jobs. Unfortunately i'm super busy working on another project at the moment. so i will not be able to really investigate whether there is an issue elsewhere in our composer dependencies until i am back looking at this again.
I'm just hoping that by the time i'm asked to actually install it, perhaps this issue may have been sorted ;)
Can you please try on your 1.9 branch with composer require setono/sylius-gift-card-plugin "^0.12.0" -W
Hello everyone. This should have been fixed now in #199. Could any of you try to install the branch 0.11 before we release 0.11.8?
@loevgaard thanks, I will do that.
Have been working on something else for a while now, but i will check this all out when i come back to this in due course.