Documentation
khizirsiddiqui opened this issue · 2 comments
khizirsiddiqui commented
Description
Undocumented parts:
- Parameters to
init
ofBaseClass
are undocumented. calculate_kd_loss()
for every class other thanBaseClass
.- All
NoisyTeacher
,orignal
,attention
require params in addition toBaseClass
params. - Citations to papers in classes definition (?)
- ResNet and other Models
This is not a priority obviously, we can do them in between other new paper implementations, I guess.
Het-Shah commented
I guess we should be doing all of this as of now shouldn't take much time as well. @avishreekh, Can you take this up?
avishreekh commented
I guess we should be doing all of this as of now shouldn't take much time as well. @avishreekh, Can you take this up?
Yes sure