[SUGGESTION] all item flags hidden
EquipableMC opened this issue · 9 comments
Suggestion
Ever since the new SkBee item flags update, you removed the option to hide all item flags. This should come back as people (like myself) like to hide all item flags and not a singular one.
Alternatives
Using NBT Compounds would work yes, but that feels silly when you could just do with all item flags hidden
Additional Information
No response
If only reading the changelog was a possibility
I did read the changelog, and I did that, and it throws an error
please read it again
I have
oh I see now, why did you remove hidden though? Seems more confusing
I re-wrote it to better match Minecraft/Bukkit
Each flag hides something, as their name implies hide enchants for example is an item flag.
adding all flags, would add each one of the flags, and each flag hides something.
I wanted this to be more future friendly, in the event mc/bukkit adds something that maybe doesn't hide, but does something else.
Why not do hide all item flags? Since there is hide enchant item flags? Just a little suggestion of course.
because "hide enchants" is the name of the flag.
If you want more info:
https://hub.spigotmc.org/javadocs/spigot/org/bukkit/inventory/meta/ItemMeta.html#addItemFlags(org.bukkit.inventory.ItemFlag...)
https://hub.spigotmc.org/javadocs/spigot/org/bukkit/inventory/ItemFlag.html
Like I said previously, Im following more of what Bukkit is doing.
My previous expression was poorly named, and I decided to rename to match bukkit.
And as I previously stated, if MC/Bukkit were to add a flag that isn't meant to hide something "hide all flags" would just not make sense.
Im not changing this expression!