ShaneIsrael/fireshare

[Bug] Public Upload Card shown when Public Upload is denied

t0g3pii opened this issue · 2 comments

Describe the bug
Show Public Upload Card can be activated when Allow Public Upload is not checked.

To Reproduce
Steps to reproduce the behavior:

  1. Go into Settings
  2. Disable Allow Public Upload
  3. Enable Show Public Upload Card
  4. Upload a Video non logged in.
  5. Get an (Un)expected Error

Expected behavior
Show Public Upload Card should be disabled (greyed out)

Screenshots
If applicable, add screenshots to help explain your problem.
direct
direct (1)

Here's an example of how it could look like
(just added color of rgb(85, 90, 95) to the label and span with a class called "css-disabled" and added the disabled attribute to the input so it can't be checked)
direct (2)

Not so much a bug but a slight oversight. I'll leave this open so that I can remember to fix the issue when I have some time.