Performance problem on adding properties with cardinality list.
Closed this issue · 3 comments
We use the very inefficient ":+" operation when adding node properties of list cardinality.
Here is the code position I mean:
This operation alone takes 6 minutes to add properties on IOFlow nodes for a 12 min cpg2sp run for a customer jar. I strongly suggest adding the new property at the beginning or using a different data structure.
Is the workaround in ShiftLeftSecurity/codepropertygraph#730 sufficient for now, or should I resolve this as well?
As you know we're moving away from the tinkerpop api, but it's a slow process with many interruptions.
I does not have high priority but since we most likely will have the updateSpecificProperty method in our interface for quite some more times, we should fix this if it is not a big change.
closing: we don't use Cardinality.list any more.
n.b. the codegen still generates this code, but that'll go out shortly as well.