Include a Shipbook reference to InnerLog output
vicfran opened this issue · 2 comments
Hey Elisha!
I would want to discuss with you the chance to include a Shipbook reference on InnerLog logs in order to easily identify them on Logcat output. I think it could be interesting for library client.
This is something other libraries do, so you can easily filter its logs on Logcat by applying a filter, for example a common Logcat output can be like:
2021-04-05 16:54:13.331 1836-1836/com.app I/FirebaseApp: Device unlocked: initializing all Firebase APIs for app
2021-04-05 16:54:13.432 1836-1836/com.app W/FirebaseCrashlytics: A new version of the Google Analytics for Firebase SDK is now available. For improved performance and compatibility with Crashlytics, please update to the latest version.
2021-04-05 16:54:13.555 1836-1890/com.app D/FirebaseRemoteConfig: Persisted config file was not found.
2021-04-05 16:54:13.712 1836-1836/com.app I/Didomi: TIME MEASUREMENT - Starting time measure
2021-04-05 16:54:13.789 1836-1836/com.app D/AppsFlyer_6.0.0: Initializing AppsFlyer SDK: (v6.0.0.55)
2021-04-05 16:54:14.310 1836-1942/com.app I/PlayCore: UID: [10153] PID: [1836] AppUpdateService : Failed to bind to the service.
2021-04-05 16:54:14.335 1836-1941/com.app I/Tealium-5.5.4: Initialized instance
Could you find interesting to include reference to Shipbook at messages logged by InnerLog? Maybe something like
2021-04-05 17:25:34.363 2313-2382/com.app D/Shipbook-SessionManager: ======== current thread: shipbook
Or maybe you can find interesting to let the Shipbook reference as the TAG and move the class name to the beginning of the message:
2021-04-05 17:25:34.363 2313-2382/com.app D/Shipbook: SessionManager ======== current thread: shipbook
What do you think? Do you think this is useful?
It is a good idea. We added the ======== signs so that it would be easy to search shipbook logs. We will check what we can do with adding also the word shipbook