Facets broken on new update — missing data-id (fix included)

[drewlonious]

Describe the current behavior

facets.js?v=105670031958728952761713395503:97 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'innerHTML') at FacetFiltersForm.renderProductGridContainer (facets.js?v=105670031958728952761713395503:97:46) at facets.js?v=105670031958728952761713395503:78:26

Describe the expected behavior

section main-collection-product-grid.liquid is missing data-id="{{ section.id }} attribute

Version information (Dawn, browsers and operating systems)

• Dawn Version: 13.0.1
• Chrome Version 108.0.5359.124
• macOS Version 13.1

Possible solution

section main-collection-product-grid.liquid

is missing data-id="{{ section.id }} attribute. Adding data-id fixes the issue

Additional context/screenshots


You can see in the fetch GET request that section_id=undefined

[joshistoast]

Thankfully I caught this issue before I merged the updates into my live store. Very peculiar that nobody caught that document.getElementById('product-grid').dataset.id no longer exists, this would've easily and quickly been caught had basic testing been done before merging.

[joshistoast]

Might benefit to roll back release until this is fixed? @ludoboludo

[ludoboludo]

@joshistoast hey, that issue was fixed for the release (on the release branch first) and should be in the main branch now as of last night: #3436

[joshistoast]

@joshistoast hey, that issue was fixed for the release (on the release branch first) and should be in the main branch now as of last night: #3436

Ahh I didn't see that, thanks! @drewlonious maybe this issue can be closed now.

[drewlonious]

@ludoboludo @joshistoast Awesome! Closing!