Shopify/homebrew-shopify

Homebrew: Warning: Calling `def fetch` ... is deprecated!

petercampanelli opened this issue · 5 comments

petercampanelli commented

Started getting this warning today with Homebrew.

Warning: Calling `def fetch` in a subclass of `Formulary::FormulaNamespaceeb7b122968da77c64c30f8a803c0134c::ThemeCheck::RubyGemsDownloadStrategy` is deprecated! Use `def fetch(timeout: nil, **options)` and output a warning when `options` contains new unhandled options instead.
Please report this issue to the shopify/shopify tap (not Homebrew/brew or Homebrew/core), or even better, submit a PR to fix it:
  /usr/local/Homebrew/Library/Taps/shopify/homebrew-shopify/theme-check.rb:16
andyw8 commented

@petercampanelli thanks for the report. I've transferred this issue to the Theme Kit repo to help us keep track of it.

  • 👍1
petercampanelli commented

@andyw8 No problem. Thank you for transferring. Might also be wise to be more specific about where to report issues since the error message says to report it to the tap. Let me know if I can help!

andyw8 commented

Might also be wise to be more specific about where to report issues since the error message says to report it to the tap.

The message comes from Homebrew itself, so unfortunately we don't have control over it.

  • 👍1
andyw8 commented

Sorry, I misread this as theme-kit instead of theme-check, feel free to transfer.

paulomarg commented

Transferred it back, thanks for reminding me!