remove @Suppress("DEPRECATION")

Question

remove @Suppress("DEPRECATION")

Closed this issue 6 years ago · 3 comments

Hi, I want to remove the @Suppress("DEPRECATION") at LiveData.kt

I want to know why deprication of SupportMediatorLiveData#observe() is suppressed.

I think It's better that showing an depricated warning when using the methods above, because Removable has a method removeObserver() to remove an observer but that does not work since removable has a different observer from the one actually observing.

And I also want to confirm that the reason you are depricating the method is what I mentioned above.

thank you in advance.

Answer 1 · 2018-10-02T10:38:48.000Z

Thanks for your feedback. I will look closer to this and make some improvements.

Answer 2 · 2018-10-19T20:27:16.000Z

@TakuSemba I get rip of deprecation as it is not necessary now. I have a PR here for upgrading to androidX and refactor the implementation. #11

About removeObserver, it shouldn't be an issue in above PR.

Answer 3 · 2019-02-01T14:34:53.000Z

All observe extensions are now removed in latest implementation. We restructure how the library works to focus on Kotlin friendly. Thanks for your feedback.