Shopify/money

Currency formatting issue on Payout > Transaction

winterweix opened this issue · 1 comments

The What

On the Payout > Transaction page:

  • If the same as store currency, use short format for all;
  • If non-store currency, use explicit format for total column in the table

Short format examples: $12.50, 12, 50 €
Explicit format examples: $12.50 CAD, 12, 50 € EUR

The Why

Recently we updated currency formatting guidelines in Polaris, and an audit through our platform resulted in us noticing a few spots where currency formatting could be unclear, especially in a multi-currency view. The suggested change would make the formatting on the Payout > Transaction coherent with the formatting suggested in the Polaris guidelines.

The How

shopify_i18n now supports the new currency formatting in ruby and typescript.

cc @mateus @robinvankampen @cejaekl

The localizing part is fixed, but waiting for the negative sign PR to be ready (merged but waiting for a gem to be bumped).
shop1 myshopify io_admin_payments_transactions