Shopify/packwerk

[Bug Report] Incompatibility with latest `zeitwerk` version (2.6.4) - undefined method `root_dirs`

iMacTia opened this issue · 5 comments

iMacTia commented

Description
packwerk breaks with latest zeitwerk fix version (2.6.4).
This is because a method considered private (root_dirs) was renamed, but it's being used by packwerk.
See this commit for more details.

To Reproduce
Update zeitwerk to v2.6.4 and run packwerk check or packwerk validate.

Expected Behaviour
The packwerk command should succeed.

Version Information

  • Packwerk: 2.2.1
  • Ruby 3.1
alexevanczuk commented

Thanks for the report 🙏 @jeffmeyers is on it! #251

  • 🎉2
iMacTia commented

Ah thanks for sharing, I missed that PR 👀 !

  • 👍1
carlost commented

any chance we could have a new packwerk release so this fix is available. I just got bit by this when updating the gems in an app.

  • 👍3
alexevanczuk commented

@carlost and other folks who emoji reacted (@benrbrook, @ericfirth, @iMacTia)

You can find the fix in this release:
https://github.com/Shopify/packwerk/releases/tag/v2.2.2

iMacTia commented

Thank you @alexevanczuk, the new release is working for us 👍 👏

  • 🚀1