Color discrepancies across codebases

Question

Color discrepancies across codebases

kaelig opened this issue 7 years ago · 8 comments

`red-light`

project	value	pr fix / resource
✅ Sketch file	`#FA9A88`
✅ polaris-styleguide	`#FEAD9A`	https://github.com/Shopify/polaris-styleguide/pull/1298
✅ polaris-rails	`#FEAF9A`
✅ polaris-react	`#FEAD9A`

`ink-base`

project	value	pr fix / resource
✅ Sketch file	`#212B36`
✅ polaris-styleguide	`#212B36`	https://github.com/Shopify/polaris-styleguide/pull/1298
✅ polaris-rails	`#212b35`
✅ polaris-react	`#212B36`

`sky-base`

project	value	pr fix / resource
✅ Sketch file	`#DFE3E8`
✅ polaris-styleguide	`#DFE3E8`	https://github.com/Shopify/polaris-styleguide/pull/1298
✅ polaris-rails	`#DFE4E8`
✅ polaris-react	`#DFE3E8`	Shopify/polaris#518

Answer 1 · 2018-02-27T01:11:39.000Z

@jessebc would it be right to assume the Sketch file has the right values?

Answer 2 · 2018-03-01T00:17:54.000Z

The sketch file has the following...
Red-light: #FA9A88
Ink-base: #212B36
sky-base: #DFE3E8

Really not sure how those diverged. I'm good going with what's in the sketch file.

Answer 3 · 2018-03-01T20:01:13.000Z

Thanks @jessebc, I updated the tables.

red-light coming from the sketch file seems waaaay off compared to the rest. Is this normal?

Answer 4 · 2018-03-05T20:03:33.000Z

Actually... it looks like the colour palette in Sketch has yet another value for red-light. :/

#FBEAE5

Really not sure where all these diverged... but we should probably pick one and run with it. Let's update the sketch files with what we have in our code implementations.

Answer 5 · 2018-03-12T19:28:46.000Z

🙃

Really not sure where all these diverged... but we should probably pick one and run with it. Let's update the sketch files with what we have in our code implementations.

Good idea.

Do you have a preference between #FEAF9A (styleguide, rails) and #FEAD9A (react)?

Answer 6 · 2018-03-19T18:08:51.000Z

Ping @jessebc 👆

Answer 7 · 2018-03-20T16:31:23.000Z

Let's go with #FEAD9A

Let me know when it's updated and I'll update the sketch file.

(How nice would it be if sketch could consume these tokens)

Answer 8 · 2018-04-13T21:49:09.000Z

polaris-rails now leverages colors from this project (thanks @nwtn and @tmlayton!), so everything should now be up to date.

(How nice would it be if sketch could consume these tokens)

RIGHT!!??

In the mean time, there's the Polaris Sketch Palette.