Yellow base misnamed?
nwtn opened this issue · 7 comments
Right now, in the Design tokens DSM library, in the Yellow palette, the base color is named Yellow (https://shopify.invisionapp.com/dsm/shopify/design-tokens/asset/colors/5ad148717ae4bf00118244be). In all the other single-color palettes, the base color is named Base (https://shopify.invisionapp.com/dsm/shopify/design-tokens/asset/colors/5ad14962303d7f0011726221).
I didn’t want to rename without checking, in case there was a reason for this.
Ah yea, that's kind of a weird one. You're right that all of the single colors use Base except Yellow but the Polaris colors use the color name [Red, Teal, etc.] instead of Base. I remember updating that previously for the Polaris colors group.
Do you think it's worth using the same pattern for the individual colors? I believe we did something in the code so that it outputs base in the tokens but displays the color name elsewhere. @kaelig @nwtn
Sounds good, that's your call :) polaris-tokens is here to adapt to whatever works best for designers – and will bridge the gap with developers.
Note: right now, developers can invariably write color('yellow') and color('yellow', 'base'). But typically they use the shorthand version color('yellow').
@sarahill can you decide on a course of action for the naming convention? As long as it's consistent, I'm good with whatever works best for you and other designers.
Sounds good! @HYPD I assigned this to you so you'd get pinged - let's pair on it together so I can walk you through the whole editing and release process with a real-world use-case 🚢
I went through the palettes and fixed it - Will have a pairing session with Dan separately to run him through how importing tokens and publishing this project works.