Shopify/polaris-tokens

Simplify colors.yml

BPScott opened this issue · 0 comments

BPScott commented

Per my comments on #66 (comment), colors.yml could be simplified

  • Make values in colors.yml use the acutal colors instead of aliases (and then we can remove the whole aliases section at the top). So https://github.com/Shopify/polaris-tokens/pull/66/files#diff-331a823dcc461b72db5ed76f9928f5a5R62 changes from value: '{!color-purple-text}' to value: '#50495a'. This changes the output of the build files so is a breaking change.
  • gulpfile.js seems to be the only place where "meta.filter" is used. The filter is generated from the color based on code from https://codepen.io/kaelig/full/jeObGP/. It may be possible to determine the filter color programatically instead of using that tool, and thus allowing us to remove meta.filter. Unfortunately the code used in that tool is currently nondeterministic. We'd need a deterministic version to enable consistent results if we generated this automatically.