Chart Inconsistencies
Closed this issue · 0 comments
envex commented
Make sure all our current charts are all up to par.
Chromatic Visual Testing
- #1307
- #1308
- #1309
- Remove redundant theme unit tests.
- ❓ If we can create a stable visual test suite, would we be confident allowing chromatic to test showing/hiding of elements so we aren't writing these tests for each component?
Design consistencies
- Ensure all charts are using shared components/constants/values for layout/placement. To be done with @adamperron
Unit Testing
- Unify drawable area logic into a hook/component.
- Write more shared unit tests for components that share logic. Ex. Annotations, Legends, etc.
- ❓ Can we write a test suite that will run the same tests for each component so we're not rewriting the same tests for multiple components.
- ❓ Can we automate a check to error if a component is missing basic tests?