Shopify/react-native-performance

Can't install `react-native-performance-navigation` as it depends on `react-native-performance@v2.0.0`

hannojg opened this issue · 0 comments

hannojg commented

Current behavior

Steps to reproduce:

npm i @shopify/react-native-performance
#  Installs version >= 4.1.2
npm i @shopify/react-native-performance-navigation
#  Throws an error as seen below

The error output

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: new.expensify@1.2.36-1
npm ERR! Found: @shopify/react-native-performance@4.1.2
npm ERR! node_modules/@shopify/react-native-performance
npm ERR!   @shopify/react-native-performance@"^4.1.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @shopify/react-native-performance@"^2.0.0" from @shopify/react-native-performance-navigation@3.0.0
npm ERR! node_modules/@shopify/react-native-performance-navigation
npm ERR!   @shopify/react-native-performance-navigation@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Expected behavior

You can install react-native-performance-navigation with the newest version of the main library.
With yarn this would have probably been ignored, but npm is more picky.

To Reproduce

Platform:

  • iOS
  • Android
  • Build tooling

Packages

Which packages are affected by the issue?

  • @shopify/react-native-performance
  • @shopify/react-native-performance-lists-profiler
  • flipper-plugin-shopify-react-native-performance
  • @shopify/react-native-performance-navigation
  • @shopify/react-native-performance-navigation-bottom-tabs
  • @shopify/react-native-performance-navigation-drawer

Environment

  • I've removed the packages that I don't use
package version
@shopify/react-native-performance 4.1.2
@react-navigation/native 6.0.13
@react-navigation/stack 6.3.1
react-native 0.70.4