Profiled Navigation throws tslint errors with react-navigation/native-stack 6.9.12
nandinicbit1981 opened this issue · 0 comments
nandinicbit1981 commented
Current behavior
Inbox team noticed tslint errors on .navigate function ( example here) when react-native/native-stack was upgraded to 6.9.12
Example:
Expected behavior
There should be no tslint errors when react-navigation packages are upgraded
To Reproduce
Please checkout this branch on inbox-client repo and dev up && dev fc. You should be able to see a bunch of tslint errors. This error also effects this upgrade
Platform:
- iOS
- Android
Packages
Which packages are affected by the issue?
- @shopify/react-native-performance
- @shopify/react-native-performance-lists-profiler
- flipper-plugin-shopify-react-native-performance
- @shopify/react-native-performance-navigation
- @shopify/react-native-performance-navigation-bottom-tabs
- @shopify/react-native-performance-navigation-drawer
Environment
- I've removed the packages that I don't use
| package | version |
|---|---|
| @shopify/react-native-performance | x.y.z |
| @shopify/react-native-performance-lists-profiler | x.y.z |
| flipper-plugin-shopify-react-native-performance | x.y.z |
| @shopify/react-native-performance-navigation | x.y.z |
| @shopify/react-native-performance-navigation-bottom-tabs | x.y.z |
| @shopify/react-native-performance-navigation-drawer | x.y.z |
| @react-navigation/native | x.y.z |
| @react-navigation/bottom-tabs | x.y.z |
| @react-navigation/drawer | x.y.z |
| @react-navigation/stack | x.y.z |
| react-native | x.y.z |