Shopify/react-native-performance

flipper-plugin-react-native-performance installation failure

ElviraBurchik opened this issue · 4 comments

ElviraBurchik commented

Current behavior

@shopify/flipper-plugin-react-native-performance plugin fails to install with an error:

Installation process of kind Install failed with: Error: ENOENT: no such file or directory, open '/var/folders/t7/3r8s1kl96_7bnd368nz4_0t00000gn/T/tmp-51806-WTB5Zxv2WO4A/@shopify__flipper-plugin-react-native-performance/package.json'

Most probably it happens because the package is prefixed with @shopify and flipper fails to find it. More details in this issue.

Expected behavior

The package can be installed successfully.

To Reproduce

Try to install plugin via Flipper UI.

Platform:

  • iOS
  • Android

Packages

Which packages are affected by the issue?

  • @shopify/react-native-performance
  • @shopify/react-native-performance-lists-profiler
  • @shopify/flipper-plugin-react-native-performance
  • @shopify/react-native-performance-navigation
  • @shopify/react-native-performance-navigation-bottom-tabs
  • @shopify/react-native-performance-navigation-drawer

Environment

  • I've removed the packages that I don't use
package version
@shopify/flipper-plugin-react-native-performance 1.0.1
ElviraBurchik commented

There is an open PR with a naive solution, hopefully we get some feedback soon.

Until then this binary can be used directly: flipper-plugin-react-native-performance-1.0.0.tgz.zip

baveku commented

There is an open PR with a naive solution, hopefully we get some feedback soon.

Until then this binary can be used directly: flipper-plugin-react-native-performance-1.0.0.tgz.zip

I can't install flipper-plugin-react-native-performance-1.0.0.tgz.zip, it's wrong format when install to Flipper

fortmarek commented

Hey @baveku 👋

Can you try with this archive instead: flipper-plugin-react-native-performance-1.0.0.tgz ? We are still waiting on a response from the Flipper team to address this properly.

  • ❤️1
baveku commented

Hey @baveku 👋

Can you try with this archive instead: flipper-plugin-react-native-performance-1.0.0.tgz ? We are still waiting on a response from the Flipper team to address this properly.

thank you very much for the best plugin, I hope we can write more plugins like this