"Guard not" is always shown, even if the guard is not negated
Closed this issue · 2 comments
eregon commented
chrisseaton commented
We can see the problem in fib-ruby.bgv
:
% bundle exec bin/seafoam examples/fib-ruby.bgv:9:1248 props | grep negated
"negated": true,
"name_template": "FixedGuard(!={p#negated}) {p#reason/s}",
% bundle exec bin/seafoam examples/fib-ruby.bgv:9:2621 props | grep negated
"negated": false,
"name_template": "FixedGuard(!={p#negated}) {p#reason/s}",
It looks like we're confusing a symbol and string property. The idea of using both was that we could use strings for properties that appear actually in the original graph, and symbols for synthetic properties we use to annotate the graph, but maybe that's confusing.
But to fix - we need to look for the string not the symbol, and we can use this graph as a test.
chrisseaton commented
Fixed by #7.