Move `YJIT` module into `RubyVM::YJIT`

Question

Move `YJIT` module into `RubyVM::YJIT`

Closed this issue 3 years ago · 4 comments

This change was requested by upstream and I'm ok with it.

We will need to update scripts in yjit-bench and yjit-metrics once this is done. @noahgibbs

Will also want to notify Jean Boussier @casperisfine to make sure our code on the deployments is up to date.

Answer 1 · 2021-10-26T13:39:16.000Z

Sounds good. I'm updating yjit-metrics now to accept either :YJIT or RubyVM::YJIT, whichever is defined. I'll do yjit-bench next.

Answer 2 · 2021-10-26T14:20:09.000Z

Looks like none of the code in yjit-bench uses the YJIT module -- no stats collected, etc -- with the exception of a random YJIT.reset_stats! in the activerecord benchmark, which I suspect shouldn't be there.

Answer 3 · 2021-10-26T15:01:31.000Z

Good plan 👍

Answer 4 · 2021-10-28T17:59:29.000Z

This is now merged: ruby/ruby#5038