Shpoike/Quakespasm

Issues with continuous integration workflow

Closed this issue · 6 comments

alexey-lysiuk commented

Continuous integration is stuck at Waiting for a runner to pick up this job... because macOS 10.15 is no longer supported by GitHub-hosted runners.

Update to macos-11 would fix this problem, but another issue arises. Failed builds are marked as succeeded.
For example, the current qsrebase HEAD, 4982206, fails with the following error.

/Users/runner/work/quakespasm-spiked/quakespasm-spiked/MacOSX/English.lproj/InfoPlist.strings:1:1: error: could not decode input file using specified encoding: Unicode (UTF-16), and the file contents appear to be encoded in Unicode (UTF-8) (in target 'QuakeSpasm-Spiked-SDL2' from project 'QuakeSpasm')

However, shell scripts do not propagate errors, i.e. there is no errexit option set. Red steps/jobs appear as green because of this.

alexey-lysiuk commented

timbergeron@e6b88db fixes this

This fixes problem with Xcode project that I mentioned as an example of incorrect continuous integration statuses.
Two issues with CI itself (the real topic of this report) are still there.

alexey-lysiuk commented

Failed build is still marked as succeeded.

/Users/runner/work/Quakespasm/Quakespasm/Quake/gl_rlight.c:526:12: error: expected ';' at end of declaration
        float s, w. frac[3];
                  ^
                  ;
/Users/runner/work/Quakespasm/Quakespasm/Quake/gl_rlight.c:533:3: error: use of undeclared identifier 'frac'
                frac[i] = (point[i] - grid->mins[i]) * grid->gridscale[i] - tile[i];
                ^
/Users/runner/work/Quakespasm/Quakespasm/Quake/gl_rlight.c:538:14: error: use of undeclared identifier 'frac'
                w =     ((i&1)?frac[0]:1-frac[0])
                               ^
/Users/runner/work/Quakespasm/Quakespasm/Quake/gl_rlight.c:538:24: error: use of undeclared identifier 'frac'
                w =     ((i&1)?frac[0]:1-frac[0])
                                         ^
/Users/runner/work/Quakespasm/Quakespasm/Quake/gl_rlight.c:539:14: error: use of undeclared identifier 'frac'
                  * ((i&2)?frac[1]:1-frac[1])
                           ^
/Users/runner/work/Quakespasm/Quakespasm/Quake/gl_rlight.c:539:24: error: use of undeclared identifier 'frac'
                  * ((i&2)?frac[1]:1-frac[1])
                                     ^
/Users/runner/work/Quakespasm/Quakespasm/Quake/gl_rlight.c:540:14: error: use of undeclared identifier 'frac'
                  * ((i&4)?frac[2]:1-frac[2]);
                           ^
/Users/runner/work/Quakespasm/Quakespasm/Quake/gl_rlight.c:540:24: error: use of undeclared identifier 'frac'
                  * ((i&4)?frac[2]:1-frac[2]);
                                     ^
Shpoike commented

There we go. Now reports failures properly.

thanks to the addition of the pmove.c and pmovetst.c files, and the xcode project being a cryptic mess of unreadable hashes I'm going to have to depend on someone rich with an overpriced mac to contribute a merge request or diff or something before it'll start working again.
but yay, now all those nice friendly green ticks are ugly angry red crosses. all is right with the world. :\

alexey-lysiuk commented

I made a PR #131 with a fix for Xcode project. Because of CI setup that doesn't build pull requests, here is a link to succeeded build from my fork.

Shpoike commented

yup, that got it, thank you.