Run tests+lint on push
DomVinyard opened this issue · 1 comments
DomVinyard commented
Task:
We know that every time we push to a branch or create a PR, a bunch of checks run within Netlify to tell us if there are any issues that would prevent our app from deploying. As part of GitHub Actions it is also possible to run our own manual checks:
We need to create a new Github action that will automatically run the web tests (npm run test
) and web linter (npm run lint
) when a push is made to any branch. This action should be configured to work with the project repository and run on each push event.
Resources
(For the linter, it may be preferable to use the Official Github Lint Action rather than use npm run lint
. You may want to do some research to find out what the distinction is.)
Acceptance Criteria:
- The Github action should run the tests and linter when a push is made to any branch.
- The Github action should be configured with the project repository.
- The Github action should run on each push event.
- The tests should only run if the linter succeeds. If the linter fails then do not run the tests after.
DomVinyard commented
edit