SilentChaos512/ExtendedDays

[Compatability] A solution to many compatibility issues and implemented work-arounds

Opened this issue · 1 comments

I posted this on the Forge page, hoping you would see it. If you have, sorry for reposing, I am just very curious about the effectiveness of this approach in your eyes.

I was experimenting with this mod and found a possibly superior way to use it. Your default is to stop the sun for some amount of time at noon and at midnight. This breaks mods like Millénaire where the NPCs won't progress their tasks until the sun resumes. This also adds the problem of the position of the vanilla sun not being a way to tell time, and as such the vanilla clock too. I found a seemingly totally effective solution to this within the bounds of your config file. In the "Extend Periods" entry you specify that the amount of time to pause the sun progress can be any number, even non-whole numbers. This gave me an idea: What if I made it so instead of doing the whole pause at one point in time I instead do a few thousand 0.01 minute pauses throughout the whole day?

So, I made a simple Python script to generate the many, many entries needed to accomplish this with the time of day and night wanted and the pause length as the inputs. I went with 37.5 minutes for day, 22.5 minutes for night, and 0.01 minute pauses. This seems to entirely solve the issues with time-progressing dependent mods like Millénaire. They never pause for any noticeable amount of time more when changing tasks which is a massive improvement over the previous 30 minutes of inactivity. This also fixes the sun and clock issue as this effectively creates about the same look as your replacement visual with default sun, and being the real sun the clock, of course, works. I only just discovered this method, the 0.01 pause is probably a bit overkill as for what is needed to have seamless game play with Millénaire and this mod, so I'll be doing further experimenting.

This has left me wondering, though, as this is a rather simple solution to problems you created pretty elaborate work-arounds for, e.g the pocket watch, clock bar, and replacement visuals, have you previously thought of doing it like this, and if so, why didn't you? Is there some issues in the long term that I've yet to encounter? Or something else?

Here is my crappy Python script for creating the entries: https://pastebin.com/dEDUh6Zp
And here is the resulting config after adding them: https://pastebin.com/yLMALh2e

I had to stop working on my modpack this year due to my PC degrading and new parts being impossible to get, but for the time I did test it I noticed absolutely no issues with any mods I had installed, even ones purported not to work such as Millénaire over several hour long play periods using this method.

I believe I remember seeing you post this on Curseforge. I mostly ignore ExtendedDays since it's 4 major updates behind already and basically abandoned. I've spent a few hours trying to port it and haven't had much luck. Probably need to rewrite the entire mod, assuming the idea can even work in newer MC versions.