Replace property NuGetPublishType by detecting type of NuGetPublishLocation
Closed this issue · 2 comments
KarlProkupek commented
Property NuGetPublishType
is actually not necessary because I saw that you convert NuGetPublishType
in targets file to add
or push
command.
I would suggest:
<NuGetPublishCmd Condition="'$(NuGetPublishLocation.ToLower().StartsWith("https://"))' == 'false'">add</NuGetPublishCmd>
<NuGetPublishCmd Condition="'$(NuGetPublishLocation.ToLower().StartsWith("https://"))' == 'true'">push</NuGetPublishCmd>
or something like that because I do not know exact syntax of these condition expressions.
Thank you for creating this package!
johnwc commented
Good point, we can just check if the value of location is a url. I'll look into this.
johnwc commented
This is in the latest version now.