SitePen/dgrid

memory leak in Keyboard.js

kalthoff opened this issue · 2 comments

In afterContentAdded() there are aspect.after() calls where the handles are never remov()ed. A few lines later other handles with on() are push()ed to grid._listeners grid._listeners.push(). What about push()ing the aspect.after handles there, too, to get them remove()d when the list is destroy()ed.

@kalthoff seems reasonable... do you have interest in creating a PR per the contributing guidelines?

Fix landed in commit 8af200e.