ImageSharp sometimes add gray rectangle at the bottom right

Question

ImageSharp sometimes add gray rectangle at the bottom right

laitauchocolat opened this issue 5 months ago · 26 comments

laitauchocolat commented 5 months ago

Prerequisites

I have written a descriptive issue title
I have verified that I am running the latest version of ImageSharp
I have verified if the problem exist in both DEBUG and RELEASE mode
I have searched open and closed issues to ensure it has not already been reported

ImageSharp version

3.1.0

Other ImageSharp packages and versions

3.0.1

Environment (Operating system, version and so on)

Windows 11

.NET Framework version

.NET 6

Description

On some picture, ImageSharp will add a gray rectangle at the bottom right,
Original:
Final:

Steps to Reproduce

Download sample projet c#
Replace fb.jpg with the original picture:

try it with version 3.0.1, (no gray square)
erease debug + obj and install the latest version 3.1.2 and execute, (gray square)

Images

No response

Answer 1 · 2024-01-15T21:11:55.000Z

@br3aker would it be possible for you to have a look at this? I thought we’d fixed it previously.

Answer 2 · 2024-01-29T20:16:57.000Z

I got the same thing net8.0

I save it like this:

using var fstream = file.OpenReadStream(); // file is IFormFile (asp.net core)

var img = Image.Load(fstream);
await img.SaveAsync(filePath, new JpegEncoder { Quality = 50 });

cropping the bottom part helps avoid the problem

Answer 3 · 2024-01-30T02:04:14.000Z

Does the issue happen on decode or encode?

I got the same thing net8.0

What do you mean by this? Same version different target framework?

Answer 4 · 2024-01-30T09:22:49.000Z

@JimBobSquarePants
version 3.1.2
net8.0
the image with the gray square is the result of img.SaveAsync(filePath, new JpegEncoder { Quality = 50 });
I assume this is encode.

Answer 5 · 2024-01-30T09:23:50.000Z

OK. Can you please encode the image as Png and let me know whether the result is the same?

Answer 6 · 2024-01-30T09:59:44.000Z

using await img.SaveAsPngAsync(Path.ChangeExtension(filePath, "png")); I also get the gray square,
I'm also doing a clone and resize to 300x300 and that one also has the square.

Answer 7 · 2024-01-30T12:11:37.000Z

Decoder then. Will need to figure out the commit that broke it.

Answer 8 · 2024-02-01T12:30:18.000Z

Hm, that's strange. I'll take a look this weekend.

Answer 9 · 2024-02-02T05:55:46.000Z

Thanks @br3aker it was likely something around this. https://github.com/SixLabors/ImageSharp/pull/2516/files#diff-2ffe67fdac3f8753169905e125b8ddb27ec966025580e775f7b07e4c6f2c8d0dR215

Answer 10 · 2024-02-26T10:43:24.000Z

Thanks @br3aker it was likely something around this. #2516 (files)

That's actually it but fix is rather complex if we don't want to break existing logic with that fast 'DOS images'. Working on it atm.

Answer 11 · 2024-02-26T10:44:40.000Z

@br3aker I kid you not I was JUST this second writing a comment to see if you wanted me to have a look. 🤪

Thanks for helping out. Much appreciated!

Answer 12 · 2024-03-06T07:29:08.000Z

This also happens in Version 2.1.6. It's not an Version 3-Issue

Answer 13 · 2024-03-07T03:27:45.000Z

This also happens in Version 2.1.6. It's not an Version 3-Issue

I upgraded from 2.1.3 to 2.1.7 due to CVE-2024-27929 and am seeing the gray rectangle on certain images also.

Answer 14 · 2024-03-07T03:57:02.000Z

The same code is in both v2 and v3. Trust @br3aker in his analysis, he knows more about that decoder than anyone on the planet.

Answer 15 · 2024-03-07T06:57:24.000Z

Sounds good. Hope he will find a solution, soon :)

Answer 16 · 2024-03-18T12:30:22.000Z

Is there any update on this issue? It's negatively impacting us, and the workaround of cropping feels kinda hacky :-)

Answer 17 · 2024-03-18T12:59:23.000Z

I'll prioritize it. Stay tuned.

Answer 18 · 2024-03-18T14:45:31.000Z

I've got PRs open for the v3 and v4 branches. It's nearly 1am here now though so I'll see how reviews go in the morning.

Answer 19 · 2024-03-19T16:45:32.000Z

Thanks for the amazingly fast turnaround @JimBobSquarePants - appreciate it! Looking forward to a new version appearing on nuget soon.

Answer 20 · 2024-03-26T13:36:41.000Z

Hey @JimBobSquarePants - any chance of a new release on nuget 🙏 ? It beats building from source ourselves

Answer 21 · 2024-03-27T09:46:07.000Z

Working on it! Just gotta get one critical task done first.

Answer 22 · 2024-04-19T00:58:37.000Z

@JimBobSquarePants - Is there any chance of this being backported to v2? (we're still dependent on .NET Standard) I just tried upgrading to 2.8 from 2.3 (to address the two CVE's) and the gray rectangle appears with our test images. Thank you kindly if you're able to make this happen.

Answer 23 · 2024-04-19T01:33:09.000Z

If you open a PR against our 2.1.x release branch I can get one merged. We’re only backporting security releases in-house at the moment to stay on top of maintenance.

Answer 24 · 2024-04-19T01:42:50.000Z

If you open a PR against our 2.1.x release branch I can get one merged. We’re only backporting security releases in-house at the moment to stay on top of maintenance.

I appreciate the quick reply and certainly understand you have to prioritize your time. If I knew how to do this I absolutely would do so, I'm just not sure how to even go about attempting something like this unfortunately. Regardless, thank you for everything you do for the community here.

Answer 25 · 2024-05-08T15:14:27.000Z

Hi, I got the same issue in my project .net6.0 and the ImageSharp version is 3.1.4.
I couldn't figure out if this issue fixed in 3.1.4 or for next release, anyone help?

Answer 26 · 2024-05-10T11:59:22.000Z

Hi, I got the same issue in my project .net6.0 and the ImageSharp version is 3.1.4. I couldn't figure out if this issue fixed in 3.1.4 or for next release, anyone help?

The fix has been released. If you are still seeing an issue, please raise a separate ticket with the image in question.