SkyTemple/c-of-time

CI doesn't execute on pmdsky-debug submodule update

Closed this issue · 3 comments

tech-ticks commented

Caused by the paths filter here: https://github.com/tech-ticks/c-of-time/blob/main/.github/workflows/rust-check-ffi.yml#L3

This filter should be changed or removed to ensure that the Rust bindings are validated before updating pmdsky-debug

theCapypara commented

ah right, probably just need to add /pmdsky-debug as well.

tech-ticks commented

I've removed the filter for now to unblock the CI, we can follow up with a proper filter later. It should also include .github/ so that we can test it properly

  • 👍1
tech-ticks commented

I guess the CI setup is fine as-is right now, feel free to comment or reopen if you disagree.