Tests don't pass with Pillow 10.1.0
Closed this issue · 3 comments
In NixOS we have a problem with skytemple-files package no longer building after Pillow 10.1.0 update (which also fails in pull request #438), specifically tests test_fetch_portraits and test_to_pil_debug fail. Due to various technical limitations on our end we cannot package SkyTemple with a different version of Pillow. I tried looking into possible patches to make skytemple-files work with new version of Pillow, but admittedly it's tad too complicated for me.
There seems to be something wrong with Pillow 10.1 and SkyTemple in general.
With 10.1 they changed something related to how JPEG is handled under macOS and it doesn't launch there anymore at all.
But that's a bit of a tangent. I'll have a look at this particular issue.
This is an upstream bug: python-pillow/Pillow#7561
Potentially something we could maybe fix on our end, depending on what they do, but not sure if it's easy to solve in a way that would be compatible with < 10.1.
The second test is just because of a new default font, I'll just disable that test, it's not really important anyway, just a debugging feature (and it still works, the font just looks different).
They don't consider this a bug, so I will work on a fix on our end.