ExternalizeWazaFile + DungeonInterrupt crash on hardware
Closed this issue · 3 comments
Originally reported at https://discord.com/channels/710190644152369162/1190254594765369364
If ExternalizeWazaFile
is applied, attempting to view the Chimecho Assembly menu will cause the game to hard crash. This is confirmed to happen on NA and most likely happens on EU and JP as well.
Based on the error screen, it looks like the problematic line is around here.
Posting this in case I don't get to this soon or if someone else beats me to it.
TIL the game has a debug crash screen in the retail version.
Nah it’s just the firmware the player was using. When I play on hardware I don’t even get fancy screens like these (I wish)
Oh, small correction and a bit more info: This crash happens when applied alongside DungeonInterrupt
. The call that causes this seems to be around here
Though looking at that code, I'm a bit confused by
bl GetMovePPWithBonus
strb r0,[r5,#+0x6]
add r4,r4,#1
add r5,r5,#8
blt loop_move
Is it intended behavior for this patch to use the condition codes that GetMovePPWithBonus
ends with...?
Trying to implement a stricter loop (comparing for 4 and checking the move's validity bit) seems to work, though more testing is probably necessary before I PR