SkyTemple/skytemple

Installer unknown locale error

Frostbyte0x70 opened this issue · 11 comments

Originally reported at https://discord.com/channels/710190644152369162/1183080667110703176

Seems like the SkyTemple 1.6.0 installer fails with certain locales.
Locale error

Duplicate of #672

Duplicate of #672

The error message is not the same, are we sure it's the same issue?

ah, you are right. The error is not caught here. However I'm not really sure how to fix this, other than also just catching and ignoring the error. This seems to be an upstream Python bug, en_ID is a pretty new locale.

This is an dependency, we can't fix this.

Not even by catching and ignoring the error as you said above?

I don't think so at that point. the call is made by cairosvg to the builtin locale module, which just fails with this error. We could hot-patch locale. Maybe.
https://docs.python.org/3/library/locale.html

I still can't find anybody else with this issue, and I don't really understand how the locale module is supposed to work under Windows. I don't really know where the actual issue is.

A workaround has been found: https://discord.com/channels/710190644152369162/1259252798449651864
Maybe that can help clarify why the issue happens?

The author of that thread changed their locale to a supported one.
Sure that is a workaround, but it doesn't really help, some Windows people would need to investigate this with Python and potentially raise an upstream bug with them or PyInstaller, depending on where the bug is.

I see. Oh well, at least now we have proper instructions on what to do to avoid the problem.