Chat UI does not calculate correct content offset after fetchMessages
Closed this issue · 2 comments
In SKYChatConversationViewController: fetchMessages function end will recalculate contentOffset but I found it has two problems.
case 1:
Does not take topContentAdditionalInset into calculation, so if set topContentAdditionalInset more than 0 the offset will have problem.
case 2:
Does not take toolbar height into calculation, toolbar will cover part of message if there has enough messages to scroll.
I have gave a PR on the scroll position issue I just found. However, I cannot find any issues mentioned as the description.
The following is the screenshot when user set SKYChatConversationViewController. topContentAdditionalInset to CGFloat(100). See if this is an expected behavior.
The following screencast shows the behavior of conversation view embedded in tab bar controller. See if anything unexpected.
Verified that case 1 only occurs when there are not full page of messages. The fix is added to the PR.