SlimDX/slimdx

Recursion warning on Direct3D9::Device::DrawIndexedUserPrimitives<T>

Closed this issue · 3 comments

Submitting a patch disabling this warning as you previously did for
Direct3D9::Device::DrawIndexedUserPrimitives<S,T>.

Index: Device.cpp
===================================================================
--- Device.cpp  (revision 997)
+++ Device.cpp  (working copy)
@@ -141,6 +141,9 @@
        return DrawUserPrimitives<T>( primitiveType, 0, primitiveCount, data );
    }

+// disables bogus warning:
'SlimDX::Direct3D9::Device::DrawIndexedUserPrimitives<T>' : recursive on
all control paths,
+// function will cause runtime stack overflow
+#pragma warning(disable:4717)
    generic<typename T>
    Result Device::DrawUserPrimitives( PrimitiveType primitiveType, int
startIndex, int primitiveCount, array<T>^ data )
    {
@@ -150,6 +153,7 @@
            pinned_data, static_cast<DWORD>( sizeof(T) ) );
        return RECORD_D3D9( hr );
    }
+#pragma warning(default:4717)

    Result Device::DrawIndexedPrimitives( PrimitiveType primitiveType, int
baseVertexIndex, int minVertexIndex, 
        int numVertices, int startIndex, int primCount )

Original issue reported on code.google.com by carl.ad...@gmail.com on 1 Apr 2009 at 10:44

The comment block refers to the wrong function, typo on my part.

Original comment by carl.ad...@gmail.com on 1 Apr 2009 at 10:45

Meh, the title of the issue as well.

Original comment by carl.ad...@gmail.com on 1 Apr 2009 at 10:46

Fixed in r1008.

Original comment by Mike.Popoloski on 2 Apr 2009 at 1:40

  • Changed state: Fixed