Gift product is not removed if condition changes

Question

Gift product is not removed if condition changes

kolaente opened this issue 5 years ago · 6 comments

We have the following rule set up: If the quantity of certain products in cart is either 1,3,5,7, etc., one gift product is added to the cart. When I put 1 of these products in cart, I get one gift product.
However, when I put 2 products in cart, the first gift product is not removed, it is still in cart. Since the rule evaluates to false for 2 products, I would expect it to remove already added products.

It is also possible to remove the product from cart while keeping the gifted product.

Answer 1 · 2019-11-26T13:32:27.000Z

related to #4

Answer 2 · 2019-11-26T13:36:45.000Z

is this related? https://github.com/Smile-SA/magento2-module-gift-sales-rule/blob/master/Observer/UpdateGiftRuleActions.php#L74

Answer 3 · 2019-11-26T16:00:24.000Z

The module is doing really scary things. It relabels the "Apply discount only to these Products" and uses it for the free product selection. This does not work well. We resorted now to use https://github.com/code4business/freeproduct2 which is simpler and works :-)

Answer 4 · 2020-12-03T07:22:28.000Z

Hello @kolaente ,

is the issue still present with the last version of the module ?

Thanks,
Pierre

Answer 5 · 2020-12-03T07:25:37.000Z

Hi @PierreLeMaguer,
Thank you for checking back.
I am a colleague of @kolaente and we are no longer using this module.

Answer 6 · 2020-12-03T07:49:45.000Z

Thanks for your answer and sorry for the delay.
I'm closing the issue.