Snowflake-Labs/schemachange

schemachange cli command returns Error: Empty SQL statement if .sql file ends with comments

ArnauMunsOrenga opened this issue · 1 comments

Describe the bug

When creating a new .sql file to implement a change in our Snowflake database, the schemachange cli command returns an error: SQL compilation error: Empty SQL statement if the .sql file terminates with a comment.

The error does not appear if the file terminates with a valid SQL command.

To Reproduce
Steps to reproduce the behavior:

  1. Create an .sql script with some SQL command to be implemented in snowflake database
  2. Make sure the file ends with some comments --some comment
  3. Run schemachange CLI command
  4. See error

Expected behavior
I would expect schemachange not to return an "Empty SQL statement" error if the .sql file ends with some comments. I would expect it executes the SQL commands it finds in the .sql script, and implements changes on the database successfully.

Screenshots
image

Schemachange (please complete the following information):

  • schemachange: 3.6.1
  • Python 3.9.19
  • snowflake-connector-python 2.8.3

Additional context
Add any other context about the problem here.

We run into the same issue but it's unlikely to get fixed due to #130 (comment).

We postfix all commented out scripts with a dummy sql command like SELECT 1;