SnowflakePowered/shiratsu

Upgrade nom to v7

Closed this issue · 4 comments

alucryd commented

Hi there, would it be possible to upgrade nom to the latest version? v6 is causing issues with tarpaulin and recent rust versions, see xd009642/tarpaulin#756

Thanks in advance.

xd009642 commented

Just FYI I just checked and it nom can be changed from 6 to 7 without any code changes (breaking change was removing the nom macros which shiratsu doesn't use).

Also a github merge conflict was committed into the Cargo.lock in 75dd8b7). I've fixed it in the local version I pulled and don't mind doing a PR but it's also a small change and I see there aren't any other contributors so don't know if you're accepting PRs?

chyyran commented

Thanks for updating this for me. I don't have CI set up so let me make sure all the tests past locally and I'll go ahead and merge this.

chyyran commented

Also sorry for not replying earlier. My Github notifications have been a bit messed up so I'll have to get that fixed later.